Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude tags is overwritten in sdk #4352

Closed
tarunKoyalwar opened this issue Nov 9, 2023 · 0 comments · Fixed by #4353
Closed

exclude tags is overwritten in sdk #4352

tarunKoyalwar opened this issue Nov 9, 2023 · 0 comments · Fixed by #4353
Assignees
@tarunKoyalwar
Labels
sdk issues/features related to SDK/Library usage Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@tarunKoyalwar
Copy link
Member

Nuclei version:

main || sdk

Current Behavior:

  • when using exclude tags in filter it is being replaced by nuclei ignore file tags

Expected Behavior:

  • nuclei ignore tags should be appended instead of replaced

Anything else:

https://discord.com/channels/695645237418131507/1172124860273672212
@tarunKoyalwar tarunKoyalwar added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. sdk issues/features related to SDK/Library usage labels Nov 9, 2023
@tarunKoyalwar tarunKoyalwar self-assigned this Nov 9, 2023
@tarunKoyalwar tarunKoyalwar linked a pull request Nov 9, 2023 that will close this issue
append excludetags instead of replacing #4353
Merged
@tarunKoyalwar tarunKoyalwar mentioned this issue Nov 9, 2023
Merged
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarunKoyalwar tarunKoyalwar

Labels
sdk issues/features related to SDK/Library usage Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

append excludetags instead of replacing projectdiscovery/nuclei
2 participants
@ehsandeep @tarunKoyalwar