Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and Name attributes of network.Input() not working #4454

Closed
UnaPibaGeek opened this issue Dec 3, 2023 · 6 comments · Fixed by #4497
Closed

Read and Name attributes of network.Input() not working #4454

UnaPibaGeek opened this issue Dec 3, 2023 · 6 comments · Fixed by #4497
Assignees
Labels
Investigation Something to Investigate Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Milestone

Comments

@UnaPibaGeek
Copy link

Hello!

I've been playing with some network templates and discovered that all of them using the read attribute in network.Input() are currently failing. Only the read-size attribute in network.Request() is working properly.

Example: ftp-anonymous-login.yaml (that uses read instead of read-size).

template-fails

The timeout error is misleading.

network-capture

Modifying the code to use read-size instead resolves the issue:

code-modified it-works

This problem occurs whenever read is used, so there are many network templates failing due to this issue.

Besides that, I've noticed that adding the name attribute to an input request doesn't work. According to the documentation, the following code should work:

  - inputs:
      - data: "blahblah" 
        name: prefix
        read: 1024
      - data: "other data"
        name: other
        read: 1024

  matchers:
      - type: word
        part: prefix
        words:
          - "string-to-match in the prefix part"

However, it doesn't seem to be the case.
Please let me know if you have any questions. Thank you!

@UnaPibaGeek UnaPibaGeek added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 3, 2023
@pussycat0x pussycat0x self-assigned this Dec 4, 2023
@tarunKoyalwar tarunKoyalwar added Type: Question A query or seeking clarification on parts of the spec. Probably doesn't need the attention of all. and removed Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Dec 6, 2023
@tarunKoyalwar tarunKoyalwar self-assigned this Dec 6, 2023
@tarunKoyalwar tarunKoyalwar added Investigation Something to Investigate and removed Type: Question A query or seeking clarification on parts of the spec. Probably doesn't need the attention of all. labels Dec 6, 2023
@tarunKoyalwar
Copy link
Member

thanks for reaching out @UnaPibaGeek i am currently looking into this issue . looks like there is a issue in template as well as overall logic will update once i have more info on this

@UnaPibaGeek
Copy link
Author

Sure, I have shared the example of FTP Anonymous Login, but other network templates using read are failing in the same way. So, I assume there is an issue when the read attribute is implemented. Looking forward to your findings to learn more :)

@UnaPibaGeek
Copy link
Author

Hi! Is there any progress? I consider this a bit critical because many network templates are using the read attribute, and due to this issue they are failing :/

@ehsandeep
Copy link
Member

@UnaPibaGeek there is some issue but it's not specific to read or read-size.

read and read-size are two different things and not aliases for each other, read is used to define read size from specific network request, generally used for templates involving multi step network request and read-size is used to define read size of complete response.

we are still investigating the issue causing timeout issue, will update the ticket as soon as we have new information to share.

@ehsandeep ehsandeep added the Priority: High After critical issues are fixed, these should be dealt with before any further issues. label Dec 15, 2023
@ehsandeep ehsandeep added this to the nuclei v3.1.2 milestone Dec 15, 2023
@ehsandeep
Copy link
Member

Related issue - #4398

@ehsandeep
Copy link
Member

@UnaPibaGeek this should be fixed with latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigation Something to Investigate Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants