Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group all timeouts in nuclei to single struct and derive from single value #5214

Closed
tarunKoyalwar opened this issue May 24, 2024 · 1 comment · Fixed by #5228
Closed

Group all timeouts in nuclei to single struct and derive from single value #5214

tarunKoyalwar opened this issue May 24, 2024 · 1 comment · Fixed by #5228
Assignees
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Milestone

Comments

@tarunKoyalwar
Copy link
Member

tarunKoyalwar commented May 24, 2024

Please describe your feature request:

  • In Nuclei to improve performance and handle unexpected situations , we have employed timeouts in multiple places for example
MaxResponseHeaderTimeout -> [10 sec] -> time to wait for first byte of http response to be returned

ResponseReadTimeout (-rrt) -> [5 sec] -> network protocol conn read timeout

JsCompilerExecutionTimeout -> 1.5  x `-timeout` flag

HttpTimeout -> 3.0 x `-timeout` flag

DialTimeout -> `-timeout` flag

...

These heirarchical timeout handles conn hangs and other issues , while this is working and good , there is need to group all these together in a single struct say TimeoutVariants or something and allow configuring these from sdk

To improve UX, instead of adding flag for each timeout variant we should dervie all these values using multipliers from single flag i.e -timeout

@tarunKoyalwar tarunKoyalwar added the Type: Enhancement Most issues will probably ask for additions or changes. label May 24, 2024
@dogancanbakir dogancanbakir self-assigned this May 24, 2024
@tarunKoyalwar
Copy link
Member Author

tarunKoyalwar commented May 24, 2024

Currently the TimeoutVariants struct is expected to be added as field in ExecuterOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants