Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides not taking effect #243

Closed
idr4n opened this issue Apr 14, 2023 · 2 comments
Closed

Overrides not taking effect #243

idr4n opened this issue Apr 14, 2023 · 2 comments

Comments

@idr4n
Copy link

idr4n commented Apr 14, 2023

Hi,
Since the latest update, overrides are not taking any effect.

My config:

{
    "projekt0n/github-nvim-theme",
    lazy = false,
    priority = 1000,
    opts = {
        options = {
            styles = {
                functions = "italic",
            },
            transparent = false,
            darken = {
                sidebars = {
                    enable = true,
                    list = { "qf", "vista_kind", "terminal", "packer" },
                },
            },
        },
        overrides = function(c)
            local acc_bg = "#F0F0F0"
            return {
                -- CursorLine = { bg = "#F4F8FF" },
                CursorLine = { bg = "#F6F6F6" },
                LspReferenceText = { bg = "#E2FFE8" },
                Folded = { bg = "NONE" },
                FoldColumn = { fg = "#595959", bg = acc_bg },
                LineNr = { fg = "#595959", bg = acc_bg },
                CursorLineNr = { fg = "#000000", bg = "#C4C4C4", style = "bold" },
                SignColumn = { bg = acc_bg },
                StatusLine = { bg = "#E6E6E6", fg = "#7A83A4" },
                DiagnosticError = { fg = c.error, bg = acc_bg },
                DiagnosticWarn = { fg = c.warning, bg = acc_bg },
                DiagnosticInfo = { fg = c.info, bg = acc_bg },
                DiagnosticHint = { fg = c.hint, bg = acc_bg },
            }
        end,
    },
    config = function(_, opts)
        require("github-theme").setup(opts)
        vim.cmd("colorscheme github_light")
    end,
},
@rafaeldelboni
Copy link

colors overrides also not working with the latest commit using the theme with the hash 4bed06edc2f53fceff48afff01b7ecd74c56fdad works fine.

@ful1e5 ful1e5 closed this as completed in 29e2f90 Apr 15, 2023
@wvjgsuhp
Copy link

Just to note, I have to go back to the mentioned commit for styles to work.

options = {
  styles = { -- Style to be applied to different syntax groups
    comments = "NONE", -- Value is any valid attr-list value `:help attr-list`
    functions = "bold",
    keywords = "bold",
    types = "bold",
  },
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants