[Proposal] Launch Alertmanager and snmp_exporter with the account created by the _common module

[umatare5]

Description

Currently, Ansible creates a dedicated user for each daemon using the central _common module. Most daemons use this user to start itself. However, only alertmanager and snmp_exporter use the independent user, not this dedicated user.

ansible/roles/alertmanager/templates/alertmanager.service.j2

Lines 25 to 26 in 5df0df6

	User=alertmanager
	Group=alertmanager

ansible/roles/snmp_exporter/templates/snmp_exporter.service.j2

Lines 8 to 9 in 5df0df6

	User=nobody
	Group={{ 'nogroup' if ansible_os_family == 'Debian' else 'nobody' }}

From my understanding,

• In the current design, daemons are started using the user created with _common.
• Other exporters are started by the user created with _common as mentioned in the Reference.

How do you think about changing the account used to start alertmanager and snmp_exporter to one created by _common?

Background

• The users for alertmanager and snmp_exporter were specified in the initial commit.
  • initial migration of roles from cloudalchemy #2
• The central _common module was implemented afterward. This PR contains the user creation.
  • refactor: consolidate common tasks #425

Collection Version

❯ ansible-galaxy collection list prometheus.prometheus --format yaml | grep prometheus.prometheus -A 1
  prometheus.prometheus:
    version: 0.23.0

Affected Role

• alertmanager
• snmp_exporter

Reference

Click to show User and Group in all unit files

❯ grep -rE 'User=|Group=' --include='*.service.j2' . | sort
./roles/alertmanager/templates/alertmanager.service.j2:Group=alertmanager
./roles/alertmanager/templates/alertmanager.service.j2:User=alertmanager
./roles/bind_exporter/templates/bind_exporter.service.j2:Group={{ bind_exporter_system_group }}
./roles/bind_exporter/templates/bind_exporter.service.j2:User={{ bind_exporter_system_user }}
./roles/blackbox_exporter/templates/blackbox_exporter.service.j2:Group={{ blackbox_exporter_system_group }}
./roles/blackbox_exporter/templates/blackbox_exporter.service.j2:User={{ blackbox_exporter_system_user }}
./roles/cadvisor/templates/cadvisor.service.j2:Group={{ cadvisor_system_group }}
./roles/cadvisor/templates/cadvisor.service.j2:User={{ cadvisor_system_user }}
./roles/chrony_exporter/templates/chrony_exporter.service.j2:Group={{ chrony_exporter_system_group }}
./roles/chrony_exporter/templates/chrony_exporter.service.j2:User={{ chrony_exporter_system_user }}
./roles/fail2ban_exporter/templates/fail2ban_exporter.service.j2:Group={{ fail2ban_exporter_system_group }}
./roles/fail2ban_exporter/templates/fail2ban_exporter.service.j2:User={{ fail2ban_exporter_system_user }}
./roles/influxdb_exporter/templates/influxdb_exporter.service.j2:Group={{ influxdb_exporter_system_group }}
./roles/influxdb_exporter/templates/influxdb_exporter.service.j2:User={{ influxdb_exporter_system_user }}
./roles/ipmi_exporter/templates/ipmi_exporter.service.j2:Group={{ ipmi_exporter_system_group }}
./roles/ipmi_exporter/templates/ipmi_exporter.service.j2:User={{ ipmi_exporter_system_user }}
./roles/memcached_exporter/templates/memcached_exporter.service.j2:Group={{ memcached_exporter_system_group }}
./roles/memcached_exporter/templates/memcached_exporter.service.j2:User={{ memcached_exporter_system_user }}
./roles/mongodb_exporter/templates/mongodb_exporter.service.j2:Group={{ mongodb_exporter_system_group }}
./roles/mongodb_exporter/templates/mongodb_exporter.service.j2:User={{ mongodb_exporter_system_user }}
./roles/mysqld_exporter/templates/mysqld_exporter.service.j2:Group={{ mysqld_exporter_system_group }}
./roles/mysqld_exporter/templates/mysqld_exporter.service.j2:User={{ mysqld_exporter_system_user }}
./roles/nginx_exporter/templates/nginx_exporter.service.j2:Group={{ nginx_exporter_system_group }}
./roles/nginx_exporter/templates/nginx_exporter.service.j2:User={{ nginx_exporter_system_user }}
./roles/node_exporter/templates/node_exporter.service.j2:Group={{ node_exporter_system_group }}
./roles/node_exporter/templates/node_exporter.service.j2:User={{ node_exporter_system_user }}
./roles/nvidia_gpu_exporter/templates/nvidia_gpu_exporter.service.j2:Group={{ nvidia_gpu_exporter_system_group }}
./roles/nvidia_gpu_exporter/templates/nvidia_gpu_exporter.service.j2:User={{ nvidia_gpu_exporter_system_user }}
./roles/postgres_exporter/templates/postgres_exporter.service.j2:Group={{ postgres_exporter_system_group }}
./roles/postgres_exporter/templates/postgres_exporter.service.j2:User={{ postgres_exporter_system_user }}
./roles/process_exporter/templates/process_exporter.service.j2:Group={{ process_exporter_system_group }}
./roles/process_exporter/templates/process_exporter.service.j2:User={{ process_exporter_system_user }}
./roles/prometheus/templates/prometheus.service.j2:Group={{ prometheus_system_group }}
./roles/prometheus/templates/prometheus.service.j2:User={{ prometheus_system_user }}
./roles/pushgateway/templates/pushgateway.service.j2:Group={{ pushgateway_system_group }}
./roles/pushgateway/templates/pushgateway.service.j2:User={{ pushgateway_system_user }}
./roles/redis_exporter/templates/redis_exporter.service.j2:Group={{ redis_exporter_system_group }}
./roles/redis_exporter/templates/redis_exporter.service.j2:User={{ redis_exporter_system_user }}
./roles/smartctl_exporter/templates/smartctl_exporter.service.j2:Group={{ smartctl_exporter_system_group }}
./roles/smartctl_exporter/templates/smartctl_exporter.service.j2:User={{ smartctl_exporter_system_user }}
./roles/smokeping_prober/templates/smokeping_prober.service.j2:Group={{ smokeping_prober_system_group }}
./roles/smokeping_prober/templates/smokeping_prober.service.j2:User={{ smokeping_prober_system_user }}
./roles/snmp_exporter/templates/snmp_exporter.service.j2:Group={{ 'nogroup' if ansible_os_family == 'Debian' else 'nobody' }}
./roles/snmp_exporter/templates/snmp_exporter.service.j2:User=nobody
./roles/systemd_exporter/templates/systemd_exporter.service.j2:Group={{ systemd_exporter_system_group }}
./roles/systemd_exporter/templates/systemd_exporter.service.j2:User={{ systemd_exporter_system_user }}