Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if basic auth is used, please remove user/password from err #71

Closed
Kuckkuck opened this issue Jul 5, 2017 · 0 comments · Fixed by #75
Closed

if basic auth is used, please remove user/password from err #71

Kuckkuck opened this issue Jul 5, 2017 · 0 comments · Fixed by #75
Assignees
@metalmatze

Comments

@Kuckkuck
Copy link

Kuckkuck commented Jul 5, 2017

Hi,

it would be nice to obfuscate the username and password, when basic auth is used in the es.url. Right now on level warn the url with password us displayed in the logs. This is relevant if you the exporter on kubernetes and share the kibana instance.

https://github.com/justwatchcom/elasticsearch_exporter/blob/a743c12f7f1957ec23075a07edd05d5db82f6b62/collector/nodes.go#L996

https://github.com/justwatchcom/elasticsearch_exporter/blob/a743c12f7f1957ec23075a07edd05d5db82f6b62/collector/cluster_health.go#L228

Thanks a lot and regards,

Olaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metalmatze metalmatze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exclude basic auth credentials from log zwopir/elasticsearch_exporter
2 participants
@Kuckkuck @metalmatze