Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] Persistance lables are not being added to PVC #3871

Closed
rasmusson opened this issue Oct 6, 2023 · 0 comments · Fixed by #3985
Closed

[prometheus] Persistance lables are not being added to PVC #3871

rasmusson opened this issue Oct 6, 2023 · 0 comments · Fixed by #3985
Labels
bug Something isn't working

Comments

@rasmusson
Copy link

Describe the bug a clear and concise description of what the bug is.

I was trying to addlables to the PVC the helm chart is creating for prometheus. example values
server:
persistentVolume:
labels:
test: enabled

these are not being added to the PVC being created. Other setting work, for example setting annotations
Looking at the template it look like the lables are simply not included. Only server lables
labels:
{{- include "prometheus.server.labels". | nindent 4 }}

Compared to annotations

annotations:
{{ toYaml .Values.server.persistentVolume.annotations | indent 4 }}

What's your helm version?

Using k3s helm CRD, dont know the version of helm

What's your kubectl version?

Client Version: v1.27.2+k3s1

Which chart?

prometheus

What's the chart version?

25.1.0

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

Add labels in the helm chart values under persistentVolume

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

this is the helm CRD im using

apiVersion: helm.cattle.io/v1
kind: HelmChart
metadata:
name: prometheus
namespace: helm
spec:
repo: https://prometheus-community.github.io/helm-charts
chart: prometheus
version: {{chart_version}}
targetNamespace: monitoring
valuesContent: |-
server:
persistentVolume:
enabled: true
labels:
test: enabled
annotations:
test: enabled
size: 9Gi

  ingress:
    enabled: true
    hosts:
      - prom.homeserver.home.arpa
    annotations:
      gethomepage.dev/enabled: "true"
      gethomepage.dev/group: Monitoring
      gethomepage.dev/name: Prometheus
      gethomepage.dev/widget.type: prometheus

Anything else we need to know?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant