Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] Change storage.retention schema to allow for storage.tsdb.retention.size to be configured #3886

Closed
RohitKochhar opened this issue Oct 12, 2023 · 0 comments · Fixed by #3985
Labels
enhancement New feature or request

Comments

@RohitKochhar
Copy link

Is your feature request related to a problem ?

Currently, to set the storage.tsdb.retention.size, it must be handed to the chart via the extraFlags command, by setting storage.tsdb.retention.size=XGB.

Since Helm doesn't support appending to lists of default values, this causes the default extraFlags arguments to be overwritten, requiring them to be redefined explicitly.

Describe the solution you'd like.

I would like to change the schema of the server.retention variable so that the desired retention size could be configured by setting it as server.retention.size=XGB in values.yaml, which would then pass the desired configuration as a flag to the Prometheus server (similar to the behaviour of server.retention, which passes the desired retention time as a flag ,storage.tsdb.retention.time, to the server.)

Describe alternatives you've considered.

I have tried passing the retention size to the server using extraArgs, extraFlags and defaultFlagsOverride, but all cause the default values to be overwritten.

Additional context.

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant