Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ghcr uploads #2841

Merged
merged 1 commit into from
Dec 22, 2022
Merged

disable ghcr uploads #2841

merged 1 commit into from
Dec 22, 2022

Conversation

monotek
Copy link
Member

@monotek monotek commented Dec 22, 2022

Signed-off-by: André Bauer monotek@users.noreply.github.com

What this PR does / why we need it

Which issue this PR fixes

  • disable ghcr uploads

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

  • disabled as it constantly fails anyway

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: André Bauer <monotek@users.noreply.github.com>
@monotek monotek requested a review from a team as a code owner December 22, 2022 09:39
@monotek monotek requested a review from scottrigby December 22, 2022 09:39
@monotek monotek merged commit bdb1ecf into main Dec 22, 2022
@monotek monotek deleted the monotek-patch-1 branch December 22, 2022 10:54
cx-asafd pushed a commit to CheckmarxDev/prometheus-helm-charts that referenced this pull request Dec 29, 2022
Signed-off-by: André Bauer <monotek@users.noreply.github.com>

Signed-off-by: André Bauer <monotek@users.noreply.github.com>
@stevehipwell
Copy link
Contributor

@monotek it's a shame that this needed to be disabled. Did you try using tee to see if Helm was giving more information as to why it was throwing a 403? I know that Helm is expected to use Docker credentials as a fallback but it might be worth explicitly calling helm registry login --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} ghcr.io.

@monotek
Copy link
Member Author

monotek commented Jan 17, 2023

nope, just wanted to get rid of the ci error.
has to be investigated again.

feel free to add an pr to get it work :)

@stevehipwell
Copy link
Contributor

@monotek I have a similar pattern in my charts repo, once that's been used a few times I'll open a PR to re-instate it with any required changes.

thezanke added a commit to thezanke/flux2 that referenced this pull request Jan 28, 2023
Updates the HelmRepository and HelmRelease to remove chart
verification and switch to using the official HTTPS repository
at https://prometheus-community.github.io/helm-charts.

OCI builds have temporarily been suspended for these charts due
to pipeline errors.

See: prometheus-community/helm-charts#2841

Signed-off-by: Alex Howard <thezanke@gmail.com>
thezanke added a commit to thezanke/flux2 that referenced this pull request Jan 30, 2023
Updates the HelmRepository and HelmRelease to remove chart
verification and switch to using the official HTTPS repository
at https://prometheus-community.github.io/helm-charts.

OCI builds have temporarily been suspended for these charts due
to pipeline errors.

See: prometheus-community/helm-charts#2841

Signed-off-by: Alex Howard <thezanke@gmail.com>
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request May 16, 2023
Signed-off-by: André Bauer <monotek@users.noreply.github.com>

Signed-off-by: André Bauer <monotek@users.noreply.github.com>
souleb pushed a commit to souleb/flux2 that referenced this pull request Jul 10, 2023
Updates the HelmRepository and HelmRelease to remove chart
verification and switch to using the official HTTPS repository
at https://prometheus-community.github.io/helm-charts.

OCI builds have temporarily been suspended for these charts due
to pipeline errors.

See: prometheus-community/helm-charts#2841

Signed-off-by: Alex Howard <thezanke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants