Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-smartctl-exporter]Powermode check and drivedb extension #4844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rbjorklin
Copy link

@rbjorklin rbjorklin commented Sep 9, 2024

What this PR does / why we need it

This PR introduces two extension points to the deployment:

  • An optional extension to the smartctl drivedb via configmap
  • An optional change in behaviour to smartctl's --nocheck flag

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Robin Björklin <robin.bjorklin@gmail.com>
@rbjorklin rbjorklin requested a review from zeritti as a code owner September 9, 2024 23:09
@rbjorklin rbjorklin force-pushed the powermode-check-and-drivedb-extension branch from 5ab88c3 to fecbc61 Compare September 9, 2024 23:18
Requires: prometheus-community/smartctl_exporter#242

Signed-off-by: Robin Björklin <robin.bjorklin@gmail.com>
@rbjorklin rbjorklin force-pushed the powermode-check-and-drivedb-extension branch from fecbc61 to 910abf7 Compare September 9, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device open failed, device did not return an IDENTIFY DEVICE structure,
1 participant