Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in most recent release #795

Closed
richardARPANET opened this issue Apr 7, 2022 · 3 comments · Fixed by #796
Closed

Breaking change in most recent release #795

richardARPANET opened this issue Apr 7, 2022 · 3 comments · Fixed by #796

Comments

@richardARPANET
Copy link

  File "/usr/local/lib/python3.8/dist-packages/prometheus_flask_exporter/__init__.py", line 15, in <module>
    from prometheus_client.exposition import choose_encoder

added in 0.14.0 it seems. are you following https://semver.org/?

@jmayse
Copy link

jmayse commented Apr 7, 2022

We are experiencing this issue as well importing prometheus_client from prometheus_flask_exporter. prometheus_flask_exporter has an unversioned import of prometheus_client in their requirements.txt and this latest release of prometheus_client seems to have broken prometheus_flask_exporter. However, this is likely a breaking change for prometheus_flask_exporter, not prometheus_client, no? Updating to a more current version of prometheus_flask_exporter fixes the issue, I believe.

https://github.com/rycus86/prometheus_flask_exporter/blob/0.20.1/prometheus_flask_exporter/__init__.py#L14-L19

@csmarchbanks
Copy link
Member

Sorry about this, the breaking change was accidental, and was renamed in #776. I am happy to change it back and created #796.

Note that breaking changes are allowed in 0.x releases, but if it was a purposeful change a [CHANGE] entry would be added to the changelog.

@csmarchbanks
Copy link
Member

0.14.1 has been released with choose_encoder restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants