adding unit tests for labelsets, metrics, and fingerprints types #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }` | ||
| var c testConfig | ||
| err := json.Unmarshal([]byte(labelSetJSON), &c) |
There was a problem hiding this comment.
Hmm, it this code dead yet?
There was a problem hiding this comment.
I am not sure I follow :).
There was a problem hiding this comment.
I'm wondering if we still have code that uses this, and if not if we can delete it.
There was a problem hiding this comment.
I'll update the year in this file's license header
There was a problem hiding this comment.
Are you referring to the JSON Unmarshal specifically ? LabelSet is being used widely.
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
|
Thanks! |
alanprot
pushed a commit
to alanprot/common
that referenced
this pull request
Mar 15, 2023
Allow user to specify HTTP and gRPC bind addresses (not just ports.) (Rebase of prometheus#153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tariqibrahim tariq181290@gmail.com