Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pylint --load-plugins option in profile #315

Closed
SergeyKosarchuk opened this issue Jan 19, 2019 · 4 comments
Closed

Support pylint --load-plugins option in profile #315

SergeyKosarchuk opened this issue Jan 19, 2019 · 4 comments

Comments

@SergeyKosarchuk
Copy link
Contributor

Hi!
Is --load-plugins tool option for pylint supported by profile configuration file? Seems like this option has no effect. Here is my .prospector.yaml file.

pylint:
  disable:
    - unused-argument
    - too-few-public-methods
    - too-many-arguments
    - too-many-ancestors
    - redefined-outer-name
    - relative-beyond-top-level
  load-plugins:
    - custom-plugin

I am using prospector==1.1.6.2 and pylint==2.1.1.

@SergeyKosarchuk SergeyKosarchuk changed the title Support pylint --load-plugins option in .prospector.yaml Support pylint --load-plugins option in profile Jan 19, 2019
@Kilo59
Copy link
Contributor

Kilo59 commented Jan 23, 2019

I recently discovered this as well and may have to stop using Prospector on a few projects because of it.

I'd be happy to try to add this if someone could point me in the right direction.

I noticed that Prospector does seem able to use a select few pylint plugins.
https://prospector.readthedocs.io/en/master/profiles.html#libraries-used-and-autodetect

But using uses: - custom-plugin does not appear to work either

@chocoelho
Copy link
Contributor

Hey there @Kilo59 @SergeyKosarchuk, as of now options are limited to pylint-django, pylint-celery and pylint-flask. Sure, we can work something out to make it more flexible, but @carlio and I are kinda short-handed here. We always welcome new PRs to integrate new features, and some points worth checking are:

Also, you could always use pylint own .pylintrc while this is not yet implemented :) LMK if that works

@SergeyKosarchuk
Copy link
Contributor Author

Hey @chocoelho, thank you for help. Seems like a good opportunity for PR.

@chocoelho
Copy link
Contributor

chocoelho commented Jul 26, 2019

Closing this as prospector 1.1.7 should implement this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants