-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update dependencies / general cleanup #1356
Conversation
Regarding the JSDoc problem, from what I can tell now it seems that something broke in JSDoc a while ago related to top-level enums, which is still not fixed entirely, but also doesn't seem as bad as it once was (?). Not sure. There is a workaround in place now for top-level enums specifically ( Also, there's a lot more that could be done in addition to the changes proposed here, like replacing deprecated |
I tried your changes in my project and it looks fine. Did not test that much but at least generation of typescript definitions with node.js 12 works now. |
Got this up to date again, but besides checking OK, it appears there's something strange happening with CI now that I've never seen before? |
@dcodeIO This is indeed weird. I was able to fix the CI thing by disabling all branch protection for Anyway, right now the checks look good (all required, and all green), we can move forward! |
Co-authored-by: Alexander Fenster <fenster@google.com>
While looking into the jsdoc issues, especially #1338, I figured that we should instead update all the dependencies. So this PR
long
, which was breaking generated typingsBufferWriter.alloc
not being correctly recognized as a function (aynmore?) during type generationOn a glimpse everything seems to be working just fine after doing so, but the sheer amount of problems this can theoretically trigger still makes me nervous. So, if anyone here has the nerves to try it and validate that the jsdoc issue is gone, that the dist files still work, or that the CLI doesn't do anything unexpected now, please do :)