-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: encoding of empty Buffers #1514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked a little bit and decided it's a breaking change and should go to v7.0 which hopefully will be released soon enough.
Thanks for the update @alexander-fenster. I think it's definitely safer to release this in a major version as there might be users relying on the current behavior. |
closes #1500
fixes #885
The fix is from @jawid-h in #1500. Thanks to him.
I added tests.
Note the change in behavior:
The default value for an empty
Buffer
is now a Buffer of length 0 vs an empty array before.I have not included the generated files in this CL (
dist/*
andindex.d.ts
).Please let me know if they should be there and I'll add them.