Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request to become a maintainer #1581

Closed
taylorcode opened this issue Apr 7, 2021 · 4 comments
Closed

request to become a maintainer #1581

taylorcode opened this issue Apr 7, 2021 · 4 comments

Comments

@taylorcode
Copy link
Collaborator

taylorcode commented Apr 7, 2021

My team maintains a fork of protobufjs here https://github.com/dropbox/protobuf.js because we have not been able to merge in fixes and improvements through the PR process.

#1228
#1249
#1234
#1463
#1460
#1461

Without these changes, especially #1461, we cannot use protobufjs.

As far as I know there is no alternative to protobufjs that really works for our use case (in the browser). google-protobuf is 230kb (min) 47kb (min + gzip) according to bundlephobia and generates highly bloated code, while protobufjs-minimal is 22k (min) and 6k (min + gzip) and generates very lean code. Going forward we plan to fully embrace proto and make it the standard format for all data, api, configuration, etc.

I'd like to become a maintainer on this project primarily to help incorporate the changes we need and help ensure that this project stays alive.

@alexander-fenster
Copy link
Contributor

Hi @taylorcode,

[I'm speaking for myself here, not for my employer.]

First of all, I acknowledge that it takes a lot of time for the things to go through - we were in the same situation two years ago :) so @dcodeIO granted access to us and we managed to set up auto releases, merge some critical changes, and we do spend as much time as we could to keep the light on (though, as you understand, it's not a primary job for neither of us). I personally would love to have as much help as possible, so as long as @dcodeIO won't object, I see no problems with making you a maintainer here. After all, it's open source and we're not the owners here.

Now back to the list of PRs, I'm working on a proper proto3 JSON support to be included in v7.0 (expect one or two more weeks) and then we'll be able to release v7.0.0 (that will include #1234 and finally split the CLI and the main package). Some of the other PRs are in blocked state because we as reviewers didn't have access to editing your branch (so we can't hit the Update branch button and verify that tests pass).

Long story short - we're in the same boat here, and I'll be happy to collaborate.

@danielhochman
Copy link

+1 to adding more maintainers, and @taylorcode seems like a great candidate.

We're using pbjs for lyft/clutch. It integrates perfectly with our development flow and standardization on protos. However, we have run into a number of significant issues, many with existing stale PRs. We have been able to hack or otherwise work around many problems solely to avoid having to rely on a fork. Personally, I have shied away from contributing since my confidence that it would result in a merged fix is low. Adding more maintainers and cleaning up stale issues and PRs would really improve the overall health and outlook of the project, and should ultimately lessen the burden on each individual maintainer.

@alexander-fenster
Copy link
Contributor

I granted write access to @taylorcode and hope you will join us in triaging issues :)

@taylorcode
Copy link
Collaborator Author

I'm thrilled. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants