fix(types): reserved field in IType can contain reserved names #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
changed the title
dcodeIO
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Looks like this change should be applied to the source file, as the changes to index.d.ts would be lost when this file is regenerated.
Source location:
Line 227 in 11393ea
Command to regenerate index.d.ts:
npm run build:types
|
Thanks, done! |
dcodeIO
approved these changes
Jun 5, 2024
Merged
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing downstream problems with some recent descriptor.proto changes that add reserved names.