From 44e49b96bc291fa128ce14e9dd4d8ba1b4454a1e Mon Sep 17 00:00:00 2001 From: Protobuf Team Bot Date: Wed, 30 Aug 2023 14:05:58 -0700 Subject: [PATCH] Workaround ICE on gcc 7.5 by not having one overload call the other one with a const_cast. Fixes https://github.com/protocolbuffers/protobuf/issues/13715 PiperOrigin-RevId: 561444098 --- .../protobuf/generated_message_tctable_impl.h | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/google/protobuf/generated_message_tctable_impl.h b/src/google/protobuf/generated_message_tctable_impl.h index a0f95a698b81..7fde171cea32 100644 --- a/src/google/protobuf/generated_message_tctable_impl.h +++ b/src/google/protobuf/generated_message_tctable_impl.h @@ -580,6 +580,9 @@ class PROTOBUF_EXPORT TcParser final { static const char* FastMlS1(PROTOBUF_TC_PARAM_DECL); static const char* FastMlS2(PROTOBUF_TC_PARAM_DECL); + // NOTE: Do not dedup RefAt by having one call the other with a const_cast. It + // causes ICEs of gcc 7.5. + // https://github.com/protocolbuffers/protobuf/issues/13715 template static inline T& RefAt(void* x, size_t offset) { T* target = reinterpret_cast(static_cast(x) + offset); @@ -599,7 +602,20 @@ class PROTOBUF_EXPORT TcParser final { template static inline const T& RefAt(const void* x, size_t offset) { - return RefAt(const_cast(x), offset); + const T* target = + reinterpret_cast(static_cast(x) + offset); +#if !defined(NDEBUG) && !(defined(_MSC_VER) && defined(_M_IX86)) + // Check the alignment in debug mode, except in 32-bit msvc because it does + // not respect the alignment as expressed by `alignof(T)` + if (PROTOBUF_PREDICT_FALSE( + reinterpret_cast(target) % alignof(T) != 0)) { + AlignFail(std::integral_constant(), + reinterpret_cast(target)); + // Explicit abort to let compilers know this code-path does not return + abort(); + } +#endif + return *target; } template