Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --incompatible_enable_proto_toolchain_resolution #17075

Closed
alexeagle opened this issue Jun 7, 2024 · 1 comment
Closed

Support --incompatible_enable_proto_toolchain_resolution #17075

alexeagle opened this issue Jun 7, 2024 · 1 comment
Labels

Comments

@alexeagle
Copy link
Contributor

Bazel 7 introduces this flag, allowing users to avoid compiling protoc from sources if they desire.

When this flag is enabled, rules like py_proto_library should use Bazel's toolchain resolver to locate protoc rather than use the hard-coded //:protoc cc_binary target in this repo.

As a concrete example, 8257c44 was performed before bazelbuild/rules_python#1577 landed, so even with the toolchain resolution flag enabled, users get a build failure if their CC toolchain isn't functional.

What version of protobuf and what language are you using?
Version: latest (27.1)
Language: N/A

@alexeagle alexeagle added the untriaged auto added to all issues by default when created. label Jun 7, 2024
@acozzette acozzette added bazel and removed untriaged auto added to all issues by default when created. labels Jun 10, 2024
@alexeagle
Copy link
Contributor Author

It's possible this problem was only in py_proto_library. I don't know of other rules that exhibit this bug right now. So I'll close this with a plan to open a separate issue if users report more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants