Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future-incompatibilities raised by z3-sys #237

Closed
Xuanwo opened this issue Apr 13, 2023 · 5 comments
Closed

future-incompatibilities raised by z3-sys #237

Xuanwo opened this issue Apr 13, 2023 · 5 comments

Comments

@Xuanwo
Copy link

Xuanwo commented Apr 13, 2023

z3-sys 0.7.1 will lead to:

warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2`

This has been fixed in main, how about bumping a new version for z3-sys? Thanks.

@Xuanwo
Copy link
Author

Xuanwo commented Jun 3, 2023

Hi @waywardmonkeys and @Pat-Lafon, could you please take a look? z3-sys has not been released for 2 years.

@Pat-Lafon
Copy link
Contributor

I don't have any influence on this, it's up to @waywardmonkeys.

@waywardmonkeys
Copy link
Contributor

I've done some merges and a couple of fixes. Is there anything else before I do a 0.8 release? Should I bump z3 itself to 0.12 or just increment the patch version?

@Xuanwo
Copy link
Author

Xuanwo commented Jun 5, 2023

Should I bump z3 itself to 0.12 or just increment the patch version?

Since z3-sys is being updated to v0.8, it would be advisable to also bump z3 to version 0.12.

@waywardmonkeys
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants