Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test data #22

Closed
proway2 opened this issue Apr 21, 2022 · 2 comments
Closed

Improve test data #22

proway2 opened this issue Apr 21, 2022 · 2 comments

Comments

@proway2
Copy link
Owner

proway2 commented Apr 21, 2022

Testdata was created with FORTRAN, some values are coarse, especially all SV values. Allowed error (used in test cases) for this values is very high.

  • Check if it's possible to create more accurate testdata with C version.
  • Generate the new testdata
  • Implement a way to digest the new testdata and automatically create tests bases on it.
  • Refactor tests - decrease max allowed error for SV fields.
@proway2
Copy link
Owner Author

proway2 commented May 7, 2022

If you request the C implementation to produce data for an interval of dates, it doesn't produce SV values, unless for the last value. Although C implementation produce more accurate values (fraction part is present for all values).

@proway2
Copy link
Owner Author

proway2 commented May 9, 2022

C implementation produces NaN for near true pole values (close to 90.0 and -90.0) and for magnetic poles 86.49N 162.87E for 2020.0. It's impossible to use values produced by C version and at the same time have near poles values calculated.
There is a way of mixing values produced by C and values produced by FORTRAN (near pole values), but it's unclear what it really brings. Declination and inclination (produced by FORTRAN) already tested with very high accuracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant