Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a continous []byte buffer as param for Hash function #4

Closed
ferranbt opened this issue Jul 14, 2022 · 0 comments · Fixed by #10
Closed

Use a continous []byte buffer as param for Hash function #4

ferranbt opened this issue Jul 14, 2022 · 0 comments · Fixed by #10

Comments

@ferranbt
Copy link

The current Hash function takes as input and output parameters a slice of [32]byte objects which represent the list of objects to hash. The proposal is to replace that input with a bytes buffer []byte where all the objects are allocated continuously. This memory structure is easier to optimize and reuse in Go than the other one.

This is a fork made by @potuz with the changes and this is a PR on ferranbt/fastssz with the changes applied. The changes are minimal and the code gets 2x faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant