Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow/Deny IP Ranges by Specifying if they are Public/Private #8466

Closed
nisdas opened this issue Feb 17, 2021 · 2 comments · Fixed by #8648
Closed

Allow/Deny IP Ranges by Specifying if they are Public/Private #8466

nisdas opened this issue Feb 17, 2021 · 2 comments · Fixed by #8648
Assignees
Labels
Enhancement New feature or request Networking P2P related items

Comments

@nisdas
Copy link
Member

nisdas commented Feb 17, 2021

🚀 Feature Request

Description

Instead of listing out all the specific IP subnets for different ranges of private addresses we can instead just provide a flag to denote this. Thanks to @hanswurst37 for raising this up in #5663 .

Describe the solution you'd like

--p2p-allowlist=public or p2p-denylist=private

A user could provide a string public / private to our current allowlist/denylist flags. We simply have to supply the subnets to our connection gater and it will filter it out for us.

@nisdas nisdas changed the title Allow/Deny IP Ranges by if they are Public/Private Allow/Deny IP Ranges by Specifying if they are Public/Private Feb 17, 2021
@nisdas nisdas added Enhancement New feature or request Networking P2P related items labels Feb 17, 2021
@DigiDr
Copy link

DigiDr commented Feb 17, 2021

Agree this would be very helpful! Perhaps Prysm could provide also provide a default list as some users will find this challenging to understand and cope with.

@kevlu93
Copy link
Contributor

kevlu93 commented Mar 23, 2021

will take a look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Networking P2P related items
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants