Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block rewards - separate code version #12009

Closed
wants to merge 2 commits into from
Closed

Block rewards - separate code version #12009

wants to merge 2 commits into from

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Feb 17, 2023

What type of PR is this?

Uncomment one line below and remove others.

Bug fix
Feature
Documentation
Other

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@rkapka rkapka requested a review from a team as a code owner February 17, 2023 14:07
terencechain
terencechain requested changes Feb 17, 2023
View reviewed changes
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance! my only feedback is if this is only used by API then it should just be in the API package

@rkapka rkapka changed the title Proposer rewards Block rewards - separate code version Feb 17, 2023
@rkapka rkapka marked this pull request as draft February 17, 2023 15:42
@rkapka
Copy link
Contributor Author

rkapka commented Feb 20, 2023

Superseded by #12020

@rkapka rkapka closed this Feb 20, 2023
@rkapka rkapka deleted the proposer-rewards branch February 21, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain requested changes

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkapka @terencechain