Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make some places use sync committee period instead of epoch #14406

Merged
merged 3 commits into from
Sep 2, 2024
Merged

fix: make some places use sync committee period instead of epoch #14406

merged 3 commits into from
Sep 2, 2024

Conversation

rupam-04
Copy link
Contributor

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Some places use an epoch where a sync committee. This PR fixes that issue

Which issues(s) does this PR fix?

Fixes #14206

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@rupam-04 rupam-04 requested a review from a team as a code owner August 30, 2024 19:59
rkapka
rkapka previously approved these changes Sep 2, 2024
View reviewed changes
rkapka
rkapka reviewed Sep 2, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -113,6 +113,7 @@ In an upcoming release, we will be deprecating the gRPC gateway and renaming sev
- Fix Event stream with carriage return support
- Fix panic on empty block result in REST API
- engine_getPayloadBodiesByRangeV1 - fix, adding hexutil encoding on request parameters
- Fix some places which use an Epoch instead of a sync committee
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use sync committee period instead of epoch in createLightClientUpdate

@rkapka rkapka added this pull request to the merge queue Sep 2, 2024
Merged via the queue into prysmaticlabs:develop with commit 77c8450 Sep 2, 2024
18 checks passed
james-prysm pushed a commit that referenced this pull request Sep 6, 2024
@rupam-04 @james-prysm
fix: make some places use sync committee period instead of epoch (#14406
abbb0e7 
)

* fix: make some places use sync committee period instead of epoch

* add fix details to `CHANGELOG.md`

* update `CHANGELOG.md` comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some places return an epoch where a sync committee period is expected instead
2 participants
@rupam-04 @rkapka