move light client rpc helpers tests to core #14695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspector-Butters
changed the title
rkapka
previously approved these changes
Dec 9, 2024
added 2 commits
December 10, 2024 02:10
auto-merge was automatically disabled
December 10, 2024 01:13
Head branch was pushed to by a user without write access
rkapka
approved these changes
Dec 10, 2024
Merged
via the queue into
prysmaticlabs:develop
with commit Dec 10, 2024
7afb8c3
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other (refactor)
What does this PR do? Why is it needed?
This PR moves the tests for
IsBetterUpdate()tocore, where the function itself is defined. (This was done before onepf-light-clientbranch, but somehow got lost in merging to develop.)Which issues(s) does this PR fix?
part of #12991