Fix validator can specify gas limit #14723
Open
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
fix-validator-gas-limit
branch
from
8f877f6 to
f7c8ab8
Compare
|
please double check if the configs are saved to db by providing a config file, then restarted without the config file ( meaning it started from a saved state) , the flag should override the database's value. I think it's wrong that the file should override the flag, the flag should be removed imo prysm/config/proposer/loader/loader.go Line 131 in b7de64a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14721
This PR updates the
processProposerSettingsfunction to ensure that the gas limit is overridden correctly. If a loaded setting (from a file) is not nil, it takes priority over both the config and the flagTesting
We verified the implementation using the following scenarios:
All tests passed as expected, confirming the intended behavior