Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate peerDAS at Electra. #14734

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Activate peerDAS at Electra. #14734

merged 1 commit into from
Dec 27, 2024

Conversation

nalepae
Copy link
Contributor

@nalepae nalepae commented Dec 18, 2024

This pull requests is a step before activating peerDAS at Fulu.

Before this pull request, Prysm was only able to manage peerDAS at genesis.
With this pull request, Prysm is able to start (for example) at Deneb, then fork at Electra, with the peerDAS feature activated at Electra.

The next step is to create the Fulu boilerplate, and to activate peerDAS at Fulu.

Tested on kurtosis:

  • All nodes starting at Deneb, then transitioning to the Electra Fork
  • A node syncing from genesis (Deneb) when the network is already at Fulu, and not finalizing
  • A node syncing from genesis (Deneb) when the network is already at Fulu, and finalizing

For this last task, we had to de-activate some rate limiting for blobs, since with this rate limiting activated, Prysm was not able to sync at all.
Note: This issue is totally orthogonal to peerDAS, and is reproducible with the latest Prysm release, with Deneb (blobs) only.

@nalepae nalepae force-pushed the peerdas-at-electra-fork branch 2 times, most recently from 40b9490 to a45fed3 Compare December 19, 2024 10:48
@nalepae nalepae marked this pull request as ready for review December 19, 2024 10:49
@nalepae nalepae requested a review from a team as a code owner December 19, 2024 10:49
@nalepae nalepae requested review from saolyn, nisdas and james-prysm and removed request for a team December 19, 2024 10:49
@nalepae nalepae marked this pull request as draft December 19, 2024 10:49
@nalepae nalepae force-pushed the peerdas-at-electra-fork branch from a45fed3 to 3917b28 Compare December 21, 2024 17:59
@nalepae nalepae marked this pull request as ready for review December 21, 2024 17:59
@nalepae nalepae force-pushed the peerdas-at-electra-fork branch from 3917b28 to 3dc1dd6 Compare December 21, 2024 18:52
@nalepae nalepae changed the title Activate peerDAS at electra. Activate peerDAS at Electra. Dec 21, 2024
@nalepae nalepae merged commit 859ac00 into peerDAS Dec 27, 2024
13 checks passed
@nalepae nalepae deleted the peerdas-at-electra-fork branch December 27, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants