Error when running crosshair on MacOS, python3.9

[samuelchassot]

Hi @pschanely! I hope you're doing great!

When I try to use Crosshair on my machine (MacOS 12.0.1), installed through pip3, I get this error:

(crosshair-dev-venv) samuel@CrossHair :branch master > crosshair check test/test.py 
Traceback (most recent call last):
  File "/usr/local/bin/crosshair", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/crosshair/main.py", line 642, in main
    sys.exit(unwalled_main(cmd_args))
  File "/usr/local/lib/python3.9/site-packages/crosshair/main.py", line 592, in unwalled_main
    return check(args, options, sys.stdout, sys.stderr)
  File "/usr/local/lib/python3.9/site-packages/crosshair/main.py", line 566, in check
    for message in run_checkables(analyze_any(entity, options)):
  File "/usr/local/lib/python3.9/site-packages/crosshair/core.py", line 696, in run_checkables
    for checkable in checkables:
  File "/usr/local/lib/python3.9/site-packages/crosshair/core.py", line 709, in analyze_any
    yield from analyze_module(cast(types.ModuleType, entity), options)
  File "/usr/local/lib/python3.9/site-packages/crosshair/core.py", line 732, in analyze_module
    yield from analyze_function(FunctionInfo.from_module(module, name), options)
  File "/usr/local/lib/python3.9/site-packages/crosshair/core.py", line 772, in analyze_function
    fn_options = collect_options(pair[0]) if pair else AnalysisOptionSet()
  File "/usr/local/lib/python3.9/site-packages/crosshair/util.py", line 71, in memo_wrapper
    saved[a] = f(a)
  File "/usr/local/lib/python3.9/site-packages/crosshair/codeconfig.py", line 80, in collect_options
    parent_opts = collect_options(sys.modules[thing.__module__])
  File "/usr/local/lib/python3.9/site-packages/crosshair/util.py", line 71, in memo_wrapper
    saved[a] = f(a)
  File "/usr/local/lib/python3.9/site-packages/crosshair/codeconfig.py", line 87, in collect_options
    parent_opts = collect_options(sys.modules[parent_pkg])
  File "/usr/local/lib/python3.9/site-packages/crosshair/util.py", line 71, in memo_wrapper
    saved[a] = f(a)
  File "/usr/local/lib/python3.9/site-packages/crosshair/codeconfig.py", line 92, in collect_options
    lines = importlib.resources.read_text(thing, "__init__.py").splitlines()
AttributeError: module 'importlib' has no attribute 'resources'

Today, I setup the environment for developing on a fork (to do our coverage stuff) following this: https://crosshair.readthedocs.io/en/latest/contributing.html#contributing
and even with the virtual environment I get the same error.
This error does not occur on my Docker on Ubuntu.

Do you have any idea of where this can come from?

Thanks in advance!

Cheers

[pschanely]

Oh, this is quite a thing.

At one level, it's "just" a missing import. in codeconfig.py, we should have import importlib.resources instead of import importlib (package contents are lazily loaded). I suspect that may fix your issue.

I'm guessing that on some platforms/environments (including when we run our tests), something else imports importlib.resources beforehand so that it happens to work even though the import in this file isn't right.

I'll push a fix in a few moments - please hold!

[samuelchassot]

Great! Thanks!
Yeah we were puzzled because it works well on @Gondolav 's machine.
Thanks for the quick fix :)

[samuelchassot]

Great, thanks for the fix! it works perfectly :)