Suboptimal line split choices with wrap_long_dict_values_in_parens

[tolomea]

Describe the style change

I'm looking at differences between 22.8.0 and 23.1a1 on our code base, most of it looks really good ❤️ as always thanks for the great work

however there is one pattern of change that doesn't seem ideal, it's possible this has been flagged already, I wasn't sure what to look for.

22.8.0

            common.models.DateTimeField: (
                datetime(2020, 1, 31, tzinfo=utc) + timedelta(days=i)
            ),

23.1a1

            common.models.DateTimeField: datetime(2020, 1, 31, tzinfo=utc) + timedelta(
                days=i
            ),

when a line needs breaking there must be some logic to decide where to break it, I guess it will find multiple candidates and rank them somehow, it looks like in this case it's started favouring the later break, whereas before it was favouring the structurally more significant one

[tolomea]

I can confirm this doesn't happen in 22.12.0, so it's new in the 23 line

[yilei]

This is caused by #3440, agree it made this particular case worse. I can take a look once I have some free time.

[JelleZijlstra]

Are you running with --preview? #3440 isn't slated for the 2023 stable style, so it's less urgent to fix.

Thanks @tolomea for reporting and @yilei for diagnosing.

[tolomea]

re: --preview, yes we are, sorry I forgot to mention that, we like black so much we always want more

[ichard26]

Just for future reference, please make it very clear which style your feedback is for. As you would imagine we care a lot more about feedback for the 2023 stable style and we'll assume any feedback on 23.1a1 to be about it unless noted.

I'll also make this more clear in the main thread and my blog post to avoid confusion :)

[hauntsaninja]

Repro: https://black.vercel.app/?version=stable&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4AEdAK9dAD2IimZxl1N_WlbvK5V9KEd0suDTtKdX1Rt0IE8B8P1y4aKTf-wph05QP2cby5sGqpd485SSPwV2QwU-E1gngOQulSp_dRlH2TcvOEkbiAPC-PvU03Pm2iJJx5jI2uyv1CoFx-4QcEFRMVGrJWW1CckfvLjyCtEQhNlBy-KLGmfDSh5tOeTp1s2Bk1VUCQ3WGwpRTBBzOJE80tHnzWbkiqy4xdIBJQGcOhX30956s5IAADJvImDTGspIAAHLAZ4CAADjUQHbscRn-wIAAAAABFla