Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too recent GitHub pull requests included #362

Open
susnux opened this issue Feb 27, 2024 · 2 comments · May be fixed by #363 or #376
Open

Too recent GitHub pull requests included #362

susnux opened this issue Feb 27, 2024 · 2 comments · May be fixed by #363 or #376

Comments

@susnux
Copy link

susnux commented Feb 27, 2024

If I run:

% did --since 2024-02-18 --until 2024-02-25
Status report for given date range (2024-02-18 to 2024-02-25).

The report includes this pr: nextcloud/firstrunwizard#1105
Which was created: Feb 26, 2024, 6:15 PM GMT+1

This should not be included in the date range as the 26th is not in the range.

@Felixoid
Copy link

Felixoid commented Mar 24, 2024

@psss I think it's because of these lines

did/did/cli.py

Lines 143 to 144 in 070a535

# Make the 'until' limit inclusive
opt.until.date += delta(days=1)

It looks like for github every self.options.until should have changed - delta(days=1). WDYT?

For example, /usr/bin/did --width=0 --since=2024-03-12 --until=2024-03-12 --format=markdown --debug generates the next snippet:

 INFO  Searching for pull requests created by Mikhail f. Shiryaev <mr.felixoid@gmail.com>
Mikhail f. Shiryaev <felixoid@clickhouse.com>
 DEBUG  GitHub query: https://api.github.com/search/issues?q=author:Felixoid+created:2024-03-12..2024-03-13+type:pr&per_page=100

The given URL contains the next three PRs:

image

But what I need is actually this
image

Pay attention to the created:2024-03-12..2024-03-12 on the latter screenshot.

@Felixoid Felixoid linked a pull request Mar 26, 2024 that will close this issue
@Felixoid
Copy link

A solution is presented in 125f468

@Felixoid Felixoid linked a pull request Oct 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants