From 6dc941e58dfc1d4a9714a76b921fbe11fce658ed Mon Sep 17 00:00:00 2001 From: pcloudy Date: Thu, 6 May 2021 08:44:28 -0700 Subject: [PATCH] Remove restriction on generate_pdb_file to be only used in dbg and fastbuild mode Users may want to build in opt mode and still want the pdb file to be a linking action output. See https://github.com/bazelbuild/rules_cc/issues/94#issuecomment-828254895 RELNOTES: None PiperOrigin-RevId: 372351216 --- tools/cpp/windows_cc_toolchain_config.bzl | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/cpp/windows_cc_toolchain_config.bzl b/tools/cpp/windows_cc_toolchain_config.bzl index 042d5193b4905f..f43f8ba3262ba3 100644 --- a/tools/cpp/windows_cc_toolchain_config.bzl +++ b/tools/cpp/windows_cc_toolchain_config.bzl @@ -666,10 +666,6 @@ def _impl(ctx): generate_pdb_file_feature = feature( name = "generate_pdb_file", - requires = [ - feature_set(features = ["dbg"]), - feature_set(features = ["fastbuild"]), - ], ) output_execpath_flags_feature = feature(