Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated bio #118

Merged
merged 4 commits into from
Jan 11, 2021
Merged

updated bio #118

merged 4 commits into from
Jan 11, 2021

Conversation

demkodo
Copy link
Contributor

@demkodo demkodo commented Dec 2, 2020

@demkodo demkodo requested a review from ElenaFdR December 2, 2020 14:26
Copy link
Member

@ElenaFdR ElenaFdR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!

added link to LinkedIn
@demkodo demkodo requested a review from ElenaFdR December 8, 2020 12:15
@demkodo
Copy link
Contributor Author

demkodo commented Dec 8, 2020

wow, the error Travis is throwing at us (999 no error) seems to be a thing for years already:
gjtorikian/html-proofer#215
I don't know how I can resolve it. I do still want to link to my LinkedIn :)
Help!!!

@bvhme
Copy link
Member

bvhme commented Dec 8, 2020

Hey Deborah, we don't link to LinkedIn profiles since the content cannot be viewed without agreeing to their terms of service, this is hostile towards the user since it forces them to give up their rights to view the content and thus it would not be moral for us to link to that. If there is another place where that content is available like a personal site you can link that.

@demkodo
Copy link
Contributor Author

demkodo commented Dec 8, 2020

Hey Deborah, we don't link to LinkedIn profiles since the content cannot be viewed without agreeing to their terms of service, this is hostile towards the user since it forces them to give up their rights to view the content and thus it would not be moral for us to link to that. If there is another place where that content is available like a personal site you can link that.

Ah that's a valid point! I'll add the link to my website instead :) thanks!!

@bvhme bvhme merged commit f2b1273 into develop Jan 11, 2021
@bvhme bvhme deleted the update-bio-deborah branch November 24, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants