Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jQuery to dependencies list for tests #492

Closed
tsparksh opened this issue Dec 24, 2019 · 3 comments
Closed

Add jQuery to dependencies list for tests #492

tsparksh opened this issue Dec 24, 2019 · 3 comments
Labels
bug

Comments

@tsparksh
Copy link
Member

We have jQuery in our package.json, but we have not it in dependencies list for phantom js tests
@tsparksh tsparksh added the bug label Dec 24, 2019
@welcome
Copy link

welcome bot commented Dec 24, 2019

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@tsparksh tsparksh mentioned this issue Dec 24, 2019
Closed
5 tasks
@sashadev-sky
Copy link
Member

@tsparksh is this related to the travis build fail in #491? Don't think we need jquery for tests. Please see my comment there!

@sashadev-sky
Copy link
Member

closing this, not relevant anymore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add jquery to tests dependencies list tsparksh/Leaflet.DistortableImage
2 participants
@tsparksh @sashadev-sky