Adjust CSS styling of rich text toolbar to Bootstrap 4 for consistency

[jywarren]

I think the lines of code could be somewhere around here?

PublicLab.Editor/src/adapters/PublicLab.Woofmark.js

Line 372 in cf1fc4a

$(".wk-switchboard button").addClass("btn-sm");

See how the buttons here don't match -- i think the basic buttons are via woofmark but the black-outlined ones are the ones we've added programmatically after woofmark is loaded. We'd love help with this, it probably will take some trial and error but isn't such a complex change!

Originally posted by @jywarren in #663 (comment) (cc @keshav234156, noting I've split this out!)

[eynglv]

@jywarren hi, could i take this bug? would be my first open source contribution

are you looking to change the outline (make all the buttons outlined) or you want them to be basic (via woofmark)?

[devan5hu]

@jywarren Hello! I am fairly new to contributing to major repositories on Github in-fact this is my very first comment. I started working on this issue today and found out the fix for it. Just wanted to share a picture of the result before I created a new branch. The changes were very minor and I want to know if its correct!

I also fixed the Custom Insert button in responsive view.

Please correct me if I am wrong and you expected something else!

[Goodiec]

Hi, @jywarren, I'm Goodness, an Outreachy applicant interested in contributing to the "Refine the Public Lab Rich Editor" project. I would like to if this issue is still open and if I can work on it.

[jywarren]

Hi @Goodiec we'd love a contribution here. I wonder if #705 already gets at part of it? However i wonder if it could be done more efficiently in a single CSS selector instead of individually for each.

I'm also not sure if this recent tweak I made may have resolved the issue as well?

b1cb346

But, if you can try it out locally with the latest code to confirm, we should be able to close this issue one way or another. Thank you!!!

[Goodiec]

Hi @Goodiec we'd love a contribution here. I wonder if #705 already gets at part of it? However i wonder if it could be done more efficiently in a single CSS selector instead of individually for each.

I'm also not sure if this recent tweak I made may have resolved the issue as well?

b1cb346

But, if you can try it out locally with the latest code to confirm, we should be able to close this issue one way or another. Thank you!!!

Sure, I'll try that. Thank you!

[RaviAnand111]

hey @jywarren @TildaDares @NARUDESIGNS, can I work on this issue ?

[TildaDares]

@RaviAnand111 I think this issue has been resolved. I checked on my local environment and all of the buttons match.

[TildaDares]

Thanks @RaviAnand111! I think we can close this issue now.

[RaviAnand111]

Hey @TildaDares, I checked my local environment and all the buttons do not match,

Do you know why is this happening?

[TildaDares]

@RaviAnand111 Have you pulled changes from this repo recently?

[RaviAnand111]

yes I did, git status, says uptodate see

[RaviAnand111]

see this the result of git pull upstream main

[TildaDares]

@RaviAnand111 I can see what you see now. I just updated my local repo.

[RaviAnand111]

No, I didn't, Should I do it right now ?

[TildaDares]

I've just assigned you @RaviAnand111

[RaviAnand111]

Thanks @TildaDares ,
I just had this 1 doubt, should I create a different branch every time I work on different issue or should I work in the main branch ?

[TildaDares]

@RaviAnand111 It's better to create a different branch when you work on different issues so that you can isolate your changes from your main branch.

[RaviAnand111]

ok, now I understand, ThankYou for explaining, you are like an elder sister who helps me whenever I am in trouble,
ThankYou

[NARUDESIGNS]

ok, now I understand, ThankYou for explaining, you are like an elder sister who helps me whenever I am in trouble, ThankYou

Lol yeah, she's amazing. In my case, she'd always help me with very useful resources.
You are doing a great job as well my friend @RaviAnand111

[RaviAnand111]

Thanks alot, @NARUDESIGNS, it is really a complement, getting thumps up from you guys. ❤️

[RaviAnand111]

Does this look good ? @TildaDares @NARUDESIGNS

[RaviAnand111]

Closer look

[NARUDESIGNS]

@RaviAnand111 I think someone might have worked on this before. Here - #705
This is a very good job by the way!

[RaviAnand111]

yeah, #705 has already solved it, so should I leave it and work on some other issue ?,
yeah, sure you can tell me about UI changes if you want.
Thanks