Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn.lock vs. package-lock.json #2035

Closed
jywarren opened this issue Jan 15, 2022 · 1 comment · Fixed by #2036
Closed

yarn.lock vs. package-lock.json #2035

jywarren opened this issue Jan 15, 2022 · 1 comment · Fixed by #2036

Comments

@jywarren
Copy link
Member

This has come up a couple times - why do we have both yarn.lock and package-lock.json? I think it may have simply been an oversight. Comments by @daemon1024 and @harshkhandeparkar: #1899 (comment), #1791 (comment)

We're facing an issue with yarn.lock in our latest release process 3.7.0/3.7.1 - #1751

So maybe let's just resolve this! Both files were originally added a LONG time ago by @tech4GT in #414

Given that our package.json specifies npm install i think that's our standard:

"setup": "npm i && npm i -g grunt grunt-cli && npm rebuild --build-from-source && grunt build",

I propose we drop yarn.lock as a result. I believe yarn can read package-lock.json anyways? I'm going to try this in releasing 3.7.1 in #1751.

Open to suggestions/feedback!

@jywarren jywarren added the bug label Jan 15, 2022
@jywarren
Copy link
Member Author

(noting that according to this, which could be out of date, yarn.lock stores a little bit less information anyways, and can be regenerated from package-lock.json: https://classic.yarnpkg.com/blog/2018/06/04/yarn-import-package-lock/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant