Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate test images into tests #29

Closed
jywarren opened this issue Jun 26, 2017 · 2 comments
Closed

Incorporate test images into tests #29

jywarren opened this issue Jun 26, 2017 · 2 comments

Comments

@jywarren
Copy link
Member

jywarren commented Jun 26, 2017

Closed #1 as it is a bit out of date now, but I still would like tests which incorporate a "before" and "after" image, as attempted in this code:

https://github.com/jywarren/image-sequencer/blob/3d43eceff9a51ed2f85c3ce42277017c7890e435/test/image-sequencer.js#L31-L59

At simplest, we could perform an operation, then reverse it -- like, for example, inverting and inverting again -- and then confirm that the image is the same after the test, perhaps using:

Or even as an initial step, do an operation on an image and expect() that it's not the same -- just confirm that /something/ happened. Then move on to more complex tests of actual test images.

If this is in another PR, please link it here, thanks!

@ccpandhare
Copy link
Collaborator

I was onto it. Got stuck at the PixelManipulation thing yet again.

@ccpandhare
Copy link
Collaborator

Now that we're done with that, I think this can be worked upon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants