'Save' button for an action is automatically disabled in UI

[Ankit-Singla]

The 'Save' button is automatically disabled whenever a new action/process is applied on any image, or after some parameters are changed and the 'Save' button is clicked. It requires being clicked two times on changing values of parameters, as it does not get autofocus when the values are changed.
@tech4GT @jywarren

[gitmate]

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #303 (Disable/dim the Add step button until a module is selected), and #302 (Disable/dim the Save button until step inputs have been changed).

[gitmate]

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #303 (Disable/dim the Add step button until a module is selected), and #302 (Disable/dim the Save button until step inputs have been changed).

[tech4GT]

hmm, yes this appears to be a problem, I think we should enable the save button on "focus" based event. Thanks for pointing out @Ankit-Singla
Would you like to work on this issue?

[Ankit-Singla]

Yes, I would love to give it a try.

[jywarren]

Merging with #377!

[tech4GT]

Okay, this is still not fixed reopening this!

[harshkhandeparkar]

The buttons works but only when the input field is updated .on('change') . That only happens when copy-paste is complete and input field is defocused or if the input field has increment and decrement buttons and they are clicked type=number. The input field doesn't receive an update while typing, it only updates after typing is complete.

[tech4GT]

Hmm, harsh I was expecting behavior where we don't have to shift focus after changing the field to enable the button.

[tech4GT]

Yeah that's what we would like fixed :)

[harshkhandeparkar]

If we add a .on('focus') event listener then the button gets focused even when the input has not changed.

[tech4GT]

Hmm, I don't think that's going to cut it since we want to enable it only when the value is changed. Maybe this needs some research work!

[harshkhandeparkar]

I think a onKeyUp or similar event listener would work but change in values should be taken into account

[tech4GT]

Harsh I think we would need to make a custom function for this, this kind of functionality usually exists in frameworks like vue and react so we can take some inspiration from there I guess.

[harshkhandeparkar]

Or we can get the initial value when the field is focused and compare it onkeyup or onchange.

[harshkhandeparkar]

inputfield.on('focus', function() {
    var initValue = inputfield.value;
    inputfield.on('change/keyup', function() {
         focusButton(initValue);
    };
};

function focusButton(initValue) {
    if (inputfield.value != initValue) {
         saveButton.focus();
    };
};

[harshkhandeparkar]

I'm trying to fix this. I'll open a PR tomorrow and we will discuss this there.