-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take a photo feature not working #631
Comments
GitMate.io thinks the contributors most likely able to help are @GitMate[bot], and @oorjitchowdhary. Possibly related issues are #353 (Adding a feature that takes width and height in percentage values.), #494 (Add 'Take a photo' as another option for initial load image step), #512 (add "take a photo" as alternative to "Choose file" in initial load image step), #213 (Crop Module not working correctly), and #557 (GIF generation is not working correctly). |
GitMate.io thinks the contributors most likely able to help are @GitMate[bot], and @oorjitchowdhary. Possibly related issues are #353 (Adding a feature that takes width and height in percentage values.), #494 (Add 'Take a photo' as another option for initial load image step), #512 (add "take a photo" as alternative to "Choose file" in initial load image step), #213 (Crop Module not working correctly), and #557 (GIF generation is not working correctly). |
I was facing the same problem too. @aashna27 ? |
I ll look into it and submit a pr soon 😊 |
Please describe the problem (or idea)
Take a Photo feature uses
navigator.getUserMedia
which has been deprecated on Insecure origins and as localhost is treated as a secure origin so we might not see this error on localhost server but on the website it's throwing an error.we should start using the newer method
https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia
but I don't know if that'll work on insecure origins or not?
and I think it'll be more helpful if we console log error object instead of error string here
https://github.com/publiclab/image-sequencer/blob/main/src/ui/SetInputStep.js#L57
Please show us where to look
http://sequencer.publiclab.org...
What's your PublicLab.org username?
Browser, version, and operating system
Chrome, Safari MacOS
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
To learn how to write really great issues, which increases the chances they'll be resolved, see:
https://publiclab.org/wiki/developers#Contributing+for+non-coders
The text was updated successfully, but these errors were encountered: