-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Width refinement to map popup display in CSS #7714
Labels
fto-candidate
issues which are meant to be solved by first timers but aren't well-formatted yet
help wanted
requires help by anyone willing to contribute
Comments
jywarren
changed the title
Refinements to popup display
Width refinement to popup display
Mar 10, 2020
jywarren
added
fto-candidate
issues which are meant to be solved by first timers but aren't well-formatted yet
help wanted
requires help by anyone willing to contribute
labels
Mar 24, 2020
jywarren
changed the title
Width refinement to popup display
Width refinement to map popup display in CSS
Mar 24, 2020
I converted this to an FTO candidate and moved it to |
Hey I was wondering if I could try and help fix this issue. I see that jessibreen has made a pull request already, so if it's already resolved then that's fine. But I'd like to help as much as I can. |
@AidenOliver, let me know if you need help finding another issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fto-candidate
issues which are meant to be solved by first timers but aren't well-formatted yet
help wanted
requires help by anyone willing to contribute
This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!
You can now see this mapping library on by default at:
https://stable.publiclab.org/map#7/41.14399650184958/-71.81762695312501
I'd like to suggest we narrow the popups a bit, to maybe 300px? They seem excessively wide. Is there a way to let them auto-size, or use the default?
Citing @jessibreen below:
It looks like the width of the popup is set in the css for that page. It has an important flag on it, so it is overriding the leaflet default of 300.
The bug is at lines 20 and 21 in https://github.com/publiclab/plots2/tree/master/app/assets/map.css
Get rid of this:
...and the popup boxes will default to their usual 300 px width.
The text was updated successfully, but these errors were encountered: