Planning Issue : Extend leaflet environmental layers

[ananyaarun]

Planning issue for Outreachy project "Extend Leaflet Environmental Layers with new layer menu and layer addition workflow "

1) Layer display and UI based issues

• color coding of layers
• improve structure in the layer selection bar (checkboxes and more info about each layer) Changed css of LEL menu #197 Changed menu width of layer menu #194
  (static template being developed)
• demarcation between layer types (group similar ones under a category etc) Categorize leaflet environmental layers based on type #188
• add meaningful names to base layers

2) Standardizing Layer code

• find similarities in code btw layers
• remove redundant code and pass layer type as parameter to a standard layer display code
  (common function which could be used to reduce redundant code in layers)
• refactoring based on common functions
• follow standard methods for each layer like layer.show() layer.hide() layer.isVisible()

3) Documentation

• create a template for layer addition
• document layer addition process
• create FTO's for adding new layers after improving documentation

4) Testing

• decide on the testing framework (jasmine or other)
• write tests
• add travis CI ? (discussion req )

[ananyaarun]

@jywarren @sagarpreet-chadha @gauravano , here is the planning issue for my project, taken from the discussions here #168
Also is it possible to get label rights for this repo ?
Thanks !

[grvsachdeva]

Hi @ananyaarun, sure we'll extend your authority. Also, you can create a project - https://github.com/publiclab/leaflet-environmental-layers/projects/new to manage the workflow once you get permissions. @jywarren also add this repo to https://github.com/orgs/publiclab/teams/soc/repositories. For now, I am adding labels. Not creating a project as you may be interested in doing that yourself (it's cool and easy way to manage 😄) .

Thanks!

[sagarpreet-chadha]

Agreed with Gaurav +1
@ananyaarun awesome 💯

[sagarpreet-chadha]

Noting @jywarren comment on revamping architecture #168 (comment) 😄 !

[ananyaarun]

@gauravano , I shall create the project myself 😃
but I am not able to create a new project, I think it requires permissions ?

[sagarpreet-chadha]

Yes it requires permission , lets wait for @jywarren to assign these permissions . Thanks !

[jywarren]

OK, i added @ananyaarun -- exciting! Thank you!

[sagarpreet-chadha]

Hey @ananyaarun , You can update the checklist above so that i can track your progress 😄 .
Also i think you can start with the second point soon (standardization of layers) . What do you think ?
Thank you !

[ananyaarun]

Yes, Even I wanted to start working on standardization of layers. Actually I have a few questions in this regard. Would it be convenient to discuss them with you sometime on gitter before I get started ? Thanks 😃

[sagarpreet-chadha]

Yes sure,
Or we can have the discussion in a seperate issue on Github so that people from different places can contribute to the discussion as well . What do you think?

[ananyaarun]

Sure, I'll open an issue shortly including the key points to take care of while going about with the standardization. We can discuss there !!

[jywarren]

Hi all! I'm closing this as many items are done and the others have been nicely broken out into issues. I'll add one issue for follow standard methods for each layer like layer.show() layer.hide() layer.isVisible() but otherwise, great work!