Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making note of new ideas and other tasks #334

Open
1 task
crisner opened this issue Jan 8, 2020 · 11 comments
Open
1 task

Making note of new ideas and other tasks #334

crisner opened this issue Jan 8, 2020 · 11 comments

Comments

@crisner
Copy link
Contributor

crisner commented Jan 8, 2020

  • We could have a url hash flag to have the menu expanded
@jywarren
Copy link
Member

jywarren commented Jan 8, 2020

  • Permalinks for popups? Like, if you open a popup maybe we can have a # button that links you back to this place AND it opens that same popup... this could be tough but useful... i don't see how we have a unique id here, but could we do it based on the layer and... timestamp? lat/lon? This might need some brainstorming.
  • Less urgent: ways to show when a layer /will be active/ for the given bounding box - do we highlight it, do we have a tooltip to explain, do we show a bounding box when people hover on the layer?

Great!

@crisner
Copy link
Contributor Author

crisner commented Jan 9, 2020

  • radio button for polygon layer groups such as justice map, indigenous lands and weather data

Some layers such as those in justice map overlap each other making it irrelevant for the layer below it to be added to the map. This is the same for some layers in the weather group. It is hard to differentiate between layers in the indigenous lands group as well. How about we make it so that only one of those layers are active at a time in each of those groups like the base layers?

  • base layers section styling

We do not show the base layer section in the layer browser menu. It will show when there are more than one base layers. Do we have plans to add more than one base layer to this control? Shall we add styling to it regardless?

  • group fracracker layers

The fractracker layers haven't been grouped because the extents for different for each layer at the time of adding it to the layer browser control. After the recent update to the fractracker_mobile layer, these could be grouped together.

  • eonet layer - get markers within bounds

I need to look into this more but right now this layer adds all the markers when it is added to the map. We could either change it to pull in markers according to the polygon as done in firetracker_mobile layer or remove the feature of requesting data on every mapend event.

  • Add documentation for layer browser menu
  • add eslint to grunt
  • Fix Uncaught TypeError: Cannot read property 'spin' of null when layer is removed from map when the spinner is still running.(Toxic Release)

@crisner
Copy link
Contributor Author

crisner commented Jan 10, 2020

@crisner
Copy link
Contributor Author

crisner commented Jan 10, 2020

Like, if you open a popup maybe we can have a # button that links you back to this place AND it opens that same popup

Ah, so when this is integrated into other sites like publiclab.org users can click the # button which would link to the LEL demo and opens the same popup?

@jywarren
Copy link
Member

Yes, that's what i was thinking, but it seems hard!

@crisner
Copy link
Contributor Author

crisner commented Jan 21, 2020

We could have a url hash flag to have the menu expanded

Is there a reason to have it as part of the URL hash? Shall we have it as a query string as this will not be dynamic and leave the hash for dynamic map parameters? I think setting the layer control's collapsed option in the one-liner code after identifying it from the query string would be simpler. @jywarren and @sagarpreet-chadha, what do think?

@crisner
Copy link
Contributor Author

crisner commented Jan 28, 2020

@crisner
Copy link
Contributor Author

crisner commented Feb 4, 2020

  • Highlight new layers when the user expands the layers menu similar to the image below
    image

@nstjean
Copy link
Contributor

nstjean commented Feb 4, 2020

  • Highlight new layers when the user expands the layers menu similar to the image below

I like that idea, it would look great!

@jywarren
Copy link
Member

jywarren commented Mar 3, 2020

Is there a reason to have it as part of the URL hash? Shall we have it as a query string as this will not be dynamic and leave the hash for dynamic map parameters? I think setting the layer control's collapsed option in the one-liner code after identifying it from the query string would be simpler. @jywarren and @sagarpreet-chadha, what do think?

That sounds great! Sorry for late response! 😓

@crisner
Copy link
Contributor Author

crisner commented Mar 4, 2020

No problem. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants