Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion regarding the time slider UI for GSoC #449

Open
Rishabh570 opened this issue Mar 27, 2020 · 1 comment
Open

Discussion regarding the time slider UI for GSoC #449

Rishabh570 opened this issue Mar 27, 2020 · 1 comment

Comments

@Rishabh570
Copy link
Contributor

Hi @jywarren, I read your feedback on my GSoC proposal, I really appreciate that. But, I was not able to comment there for some reason. I understand that CTB might not be in the top priorities this year, that blog could be useful for anyone who is trying to work on improving CTB as a project. I think that the blog could serve that purpose 🙂.

So, as per your suggestion, I'm thinking about the time slider for LEL...we need a time slider to filter the data shown on the map. I came across https://github.com/socib/Leaflet.TimeDimension while studying about the project. I guess the image shown below is somewhat similar to what we want for our project.

timeslider

(The format of time shown in the slider can be simply changed by clicking on it)

This helps in adding time dimension capabilities on a leaflet map.

In examples/layers.js, on line 315 we use overlayMaps and this includes various layers that we add to our map when needed. We need to convert these layers to time dimension layers. An example of this can be seen here. This example takes a similar approach to ours.
We convert a layer to time dimension layer by,

var layer_name_timeLayer = L.timeDimension.layer(layer_name);

But I'm not able to make it work for our overlays as of now because we have custom layers (that extends LayerGroup) and the example shown on the above link takes a tileLayer/nonTiledLayer (and not a custom layer). That's why when I'm converting the layers present in src/ to time dimension layers by using the above-shown syntax, it's not working. As I'm new to this project, I don't know how I can convert the given layers to time dimension ones.

@jywarren @sagarpreet-chadha I would really appreciate any suggestions and sorry if this is far from what we want 🙂.

@welcome
Copy link

welcome bot commented Mar 27, 2020

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant