Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Cypress tests to not depend on static layer/group counts #580

Open
jywarren opened this issue Sep 5, 2021 · 4 comments
Open

Refactor Cypress tests to not depend on static layer/group counts #580

jywarren opened this issue Sep 5, 2021 · 4 comments
Assignees
@PrimalPimmy

Comments

@jywarren
Copy link
Member

jywarren commented Sep 5, 2021

Adding a layer meant changes throughout these files to fix the overall counts. Let's make them tied to the info.json keys file instead, so they dynamically update, and that's our "source of truth":
@jywarren
Copy link
Member Author

jywarren commented Sep 5, 2021

Example in #555 changed things...

Source of truth listing of layers: https://github.com/publiclab/leaflet-environmental-layers/blob/main/src/info.json

@PrimalPimmy
Copy link

Hey, I've been looking into this issue and would like to work on this!

@daemon1024
Copy link
Member

daemon1024 commented Sep 22, 2021 •
edited
Loading

@PrimalPimmy 👋🏽 Thank You for looking into this. I have assigned this to you, feel free to reach out here if you have some queries. 🙌🏽

@jywarren
Copy link
Member Author

jywarren commented Jun 7, 2022

See also connection to #665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrimalPimmy PrimalPimmy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jywarren @PrimalPimmy @daemon1024