Get Mapknitter running into the Google Cloud v2 #1273
Conversation
|
Hey I think this one is ready to merge it appears to work both in staging/jenkins and appengine! |
Passengerfile.json.production
Outdated
| // Run Passenger on the given port. In this example, we use port 80, | ||
| // the standard HTTP port. | ||
| "port": 8080 | ||
| } |
There was a problem hiding this comment.
It was meant to set Passenger's production port to 8080. Will we still need this? @icarito
There was a problem hiding this comment.
No I don't think we still need this. At least neither Gcloud nor our docker-compose setup we have running on Jenkins use this. I have removed it from this branch, unless you see a use for it.
|
|
||
| class AllHandler(webapp.RequestHandler): | ||
| def get(self): | ||
| self.redirect("https://tycho.media.mit.edu/warps", True) |
There was a problem hiding this comment.
At some point we should use an env variable here too
There was a problem hiding this comment.
In fact this is the wrong URL, your comment made me notice. I'll fix it, sorry!
There was a problem hiding this comment.
ahh okay this is file isn't needed at all it was an attempt to use the App Engine way of redirecting.
There was a problem hiding this comment.
Good catch, I just remove this file from the main branch. Also the Environment variable is still pending, but it would be done in routes.rb
Updated rebased version of #1260
Linking #1271 and #1272 as well for tracking.
Fixes #1191
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/mapknitter-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!