Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing coordinates of people map to show more continents . #2215

Closed
4 tasks
sagarpreet-chadha opened this issue Feb 3, 2018 · 2 comments
Closed
4 tasks
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML

Comments

@sagarpreet-chadha
Copy link
Contributor

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem

Currently the people map shown here : https://publiclab.org/people/ ,
screen shot 2018-02-03 at 10 49 33 pm

This map is not at center , hence less number of users are shown .
Lets change the center coordinates of the map to show more continents when the page loads .
Like this :

screen shot 2018-02-03 at 10 50 03 pm

Solution

Lets change the coordinates here ,

<%= render :partial => "map/peopleLeaflet" , locals: {people: true , lat:17 , lon: 75} %>

to lat:23 and lon:4 .

Feel free to ask any doubt regarding the issue ! Thank you !

Steps to Fix

  • claim this issue with a comment here, below, and ask any clarifying questions you need
  • set up a repository locally following the README instructions, and make sure that all tests pass
  • try to fix the issue following the steps above, but even before you're done, you can:
    commit your changes and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
  • alert someone via the developers list (see below) to have your pull request merged. This may take a few extra steps depending on when you do it, but we'll help you out!

Please email the developers list (see https://publiclab.org/wiki/developers) or go to the chatroom if you have questions, and take a look at our first-timers landing page for more information!

@grvsachdeva grvsachdeva added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML labels Feb 4, 2018
@VarshaNairM
Copy link

I am a beginner to open source.I want to take up this and work on

@ViditChitkara
Copy link
Member

ViditChitkara commented Feb 4, 2018

Go ahead 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML
Projects
None yet
Development

No branches or pull requests

4 participants