Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render wiki pages on notes/popular #3456

Open
SidharthBansal opened this issue Sep 25, 2018 · 6 comments
Open

Render wiki pages on notes/popular #3456

SidharthBansal opened this issue Sep 25, 2018 · 6 comments
Labels
add-code-links design issue requires more design work and discussion (i.e. mockups and sketches)

Comments

@SidharthBansal
Copy link
Member

SidharthBansal commented Sep 25, 2018

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.
Instance Count 1
Area: Design

Please describe the problem (or idea)

When one clicks on the wiki on /notes/popular the person is redirected to a new page.

What happened just before the problem occurred? Or what problem could this idea solve?

Instead the person should be shown list of items below wiki nav bar

Please show us where to look

https://publiclab.org/notes/popular

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@SidharthBansal SidharthBansal added design issue requires more design work and discussion (i.e. mockups and sketches) add-code-links gci-candidate big for Google Code-In labels Sep 25, 2018
@SidharthBansal
Copy link
Member Author

Refer #2293. This pr shows how the like page was integrated into the /profile/username page.
Thanks.

@oorjitchowdhary
Copy link
Member

Do we have to write a new def wiki for this like this one here..?

def recent
@title = I18n.t('notes_controller.recent_research_notes')
@wikis = Node.limit(10)
.where(type: 'page', status: 1)
.order('nid DESC')
@notes = Node.where(type: 'note', status: 1, created: Time.now.to_i - 1.weeks.to_i..Time.now.to_i)
@unpaginated = true
render template: 'notes/index'
end

@jonxuxu
Copy link
Member

jonxuxu commented Dec 10, 2018

When I click the wiki pages button below, I'm routed directly to https://publiclab.org/wiki/ in the same tab:
image
@SidharthBansal are you still experiencing these issues?

@SidharthBansal
Copy link
Member Author

Yeah it needs ajax fix

@SidharthBansal
Copy link
Member Author

And also we need to render it downside thats rails part

@SidharthBansal
Copy link
Member Author

Oorjit no. Please look at the PR for reference given

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-code-links design issue requires more design work and discussion (i.e. mockups and sketches)
Projects
None yet
Development

No branches or pull requests

4 participants