Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align download as buttons on smaller screens #4972

Closed
5 tasks
cesswairimu opened this issue Mar 9, 2019 · 22 comments
Closed
5 tasks

Align download as buttons on smaller screens #4972

cesswairimu opened this issue Mar 9, 2019 · 22 comments
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@cesswairimu
Copy link
Collaborator

cesswairimu commented Mar 9, 2019

Created specifically for @karunagoyalk

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update:
    At https://publiclab.org/stats the download as buttons are not well aligned(To see this locally login as admin) are not aligned well on smaller screens.
    download

https://github.com/publiclab/plots2/blob/master/app/views/stats/_range.html.erb#L32-L94

Update

 <div class="row">
 <div class="col-md-4 col-md-offset-2">
</div>
&emsp;
<div class="col-md-3">
 </div>
</div>

After changing the view, also attach the screenshot of updated view in the PR. (You probably have to go on responsive design mode by pressing Ctrl+shift+M)

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

@cesswairimu
Copy link
Collaborator Author

@karunagoyalk here you go

@cesswairimu cesswairimu added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Mar 9, 2019
@GettyOrawo
Copy link
Contributor

Hello @cesswairimu has is this issue already claimed?

@grvsachdeva
Copy link
Member

Hey @GettyOrawo, this issue was created for @karunagoyalk as they were searching for an issue to take on. Are you looking for a FTO?

@karunagoyalk
Copy link
Contributor

@cesswairimu @gauravano thanks! I will work on it

@helenatxu
Copy link

Hi I am an Outreachy applicant, could I be assigned to this issue to work on? Or maybe you have another issue you could assign me to start working :) Thanks @gauravano

@cesswairimu
Copy link
Collaborator Author

Hi @karunagoyalk how is this coming along?

@karunagoyalk
Copy link
Contributor

@cesswairimu hey! Actually i faced some problem while installing and building the project.But I am trying , i will get back to you in some time with PR

@cesswairimu
Copy link
Collaborator Author

cesswairimu commented Mar 16, 2019

Okay cool. rem to checkout #3840 to see if there are any issues you are getting that was solved there or add a comment with your error and we can try and help

@karunagoyalk
Copy link
Contributor

karunagoyalk commented Mar 17, 2019

Hey! @cesswairimu I have mailed for Free invite for cloud9, But I did not get any response yet!

@cesswairimu
Copy link
Collaborator Author

cesswairimu commented Mar 17, 2019

Hey @karunagoyalk Not sure accepts the access requests for c9 but let me find out. Did you have installations problems? Maybe you can edit it on github and I will help add the screenshot for you?

@karunagoyalk
Copy link
Contributor

karunagoyalk commented Mar 17, 2019

Hey! @cesswairimu I have done the editing on github! please help me in adding screenshot.

@cesswairimu
Copy link
Collaborator Author

cool, on it

@cesswairimu
Copy link
Collaborator Author

Hey @karunagoyalk could you create a new branch.
go here
Screenshot from 2019-03-17 21-38-51

and type fix-download-buttons when the create blue highlight comes click on it..so we can make a pull request from that branch. Thanks

@karunagoyalk
Copy link
Contributor

Hey @cesswairimu I have created the branch,as per you suggested me to do!

@cesswairimu
Copy link
Collaborator Author

Awesome seen it...one last thing I want you to make the pull request. just go here https://github.com/karunagoyalk/plots2/tree/Fix-download-buttons then click the Compare button on the right side. Then just click the create pull request green button then we are set

@karunagoyalk
Copy link
Contributor

Hey @cesswairimu what is this?
Screenshot

@karunagoyalk
Copy link
Contributor

@cesswairimu Hey! I am new to open source, please help me , what to do here as I have not added any Screenshot
Screenshot from 2019-03-18 20-09-45

@cesswairimu
Copy link
Collaborator Author

I will add it for you just now...awesome creating a pull request 🎉

@cesswairimu
Copy link
Collaborator Author

Hey @karunagoyalk added the screenshot and left a comment. You can edit this by going here https://github.com/publiclab/plots2/pull/5152/files an then hit the edit kaykay
and change line 33 to <div class="col-md-4 col-md-offset-1"> after that just commit then we are ready. Thanks

@karunagoyalk
Copy link
Contributor

@cesswairimu Hey! thanks alot for helping me in creating my first PR.I have done the final editing, Can you please have a look,Let me know!

@karunagoyalk
Copy link
Contributor

@cesswairimu Hey! Can you assign me some other issue to work on?

@cesswairimu
Copy link
Collaborator Author

Hey @karunagoyalk you can through these issues https://github.com/publiclab/plots2/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22 and see if there is an issue you can work on. Feel free to ping me if you get stuck. Also I would suggest you install the code locally or have it set on C9 for easier testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

No branches or pull requests

5 participants