Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of questions and comments in topic cards in profile page #6390

Closed
2 tasks
CleverFool77 opened this issue Oct 4, 2019 · 1 comment · Fixed by #6472
Closed
2 tasks

Addition of questions and comments in topic cards in profile page #6390

CleverFool77 opened this issue Oct 4, 2019 · 1 comment · Fixed by #6472
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) feature explains that the issue is to add a new feature help wanted requires help by anyone willing to contribute

Comments

@CleverFool77
Copy link
Member

Description

We have notes added to the topic cards for that particular tag. We need Questions/comments too. So we need to add this. There are two portions -

  • First we need to add questions and comments in cards
  • Second we need to add the no of questions/comments for that topic in the cards
    Similar as notes given below.

Screenshot from 2019-10-04 12-11-18

We have to follow the style draft. Here is the screenshot of the change that is need to be done.
The code of the question, comments part would be similar to that of notes part.
The code of the notes part is already present in the codebase in file app/views/tag/_profileCard.html.erb

Screenshot from 2019-10-04 12-28-46

Thanks !!
@CleverFool77 CleverFool77 added help wanted requires help by anyone willing to contribute design issue requires more design work and discussion (i.e. mockups and sketches) feature explains that the issue is to add a new feature break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration labels Oct 4, 2019
@nstjean
Copy link
Contributor

nstjean commented Oct 14, 2019

Hi, I'd like to work on this. :)

@nstjean nstjean mentioned this issue Oct 15, 2019
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) feature explains that the issue is to add a new feature help wanted requires help by anyone willing to contribute
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add questions and comments to profile cards nstjean/plots2
3 participants
@SidharthBansal @CleverFool77 @nstjean