Change function t to translations in comments/_edit

[nstjean]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• 📝 Update the file _edit.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

In this template we need to change the function named t(....) to be named as translations(...) on lines 25, 30, 35 and 38.

plots2/app/views/comments/_edit.html.erb

Lines 23 to 43 in 50164b1

	<p>
	<span id="c<%= comment.id%>uploading" class="uploading" style="display:none;">
	<%= t('comments._edit.uploading') %>
	</span>
	<span id="c<%= comment.id%>prompt" class="prompt">
	<span style="padding-right:4px;float:left;" class="hidden-xs">
	<%= raw t('comments._edit.drag_and_drop') %>
	</span>
	<label id="c<%= comment.id%>input_label" for="c<%= comment.id%>input">
	<input id="c<%= comment.id%>input" type="file" name="image[photo]" style="display:none;" />
	<a class="hidden-xs"><%= t('comments._edit.choose_one') %></a>
	<span class="visible-xs">
	<i class="fa fa-upload"></i>
	<a><%= t('comments._edit.upload_image') %></a>
	</span>
	</label>
	</span>
	</p>

When you are done the 4 changes it should look like this:

        <p>
          <span id="c<%= comment.id%>uploading" class="uploading" style="display:none;">
            <%= translation('comments._edit.uploading') %>
          </span>
          <span id="c<%= comment.id%>prompt" class="prompt">

            <span style="padding-right:4px;float:left;" class="hidden-xs">
              <%= raw translation('comments._edit.drag_and_drop') %>
            </span>

              <label id="c<%= comment.id%>input_label" for="c<%= comment.id%>input">
              <input id="c<%= comment.id%>input" type="file" name="image[photo]" style="display:none;" />
              <a class="hidden-xs"><%= translation('comments._edit.choose_one') %></a>
              <span class="visible-xs">
                <i class="fa fa-upload"></i>
                <a><%= translation('comments._edit.upload_image') %></a>
              </span>
            </label>

          </span>
        </p>

• 💾 Commit your changes

• 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

[ricardotenv]

Can I work on it?

[nstjean]

@ricardosantosdev Sure! Let me know if you have any troubles.

[ricardotenv]

I sent the PR, what happens now?

[Johnalex-hub]

Please can I also work on this?

[ricardotenv]

Please can I also work on this?

I'm going up a possible fix now

[nstjean]

@ricardosantosdev PRs will be reviewed by others and then eventually merged by those with permissions to do so!

[ricardotenv]

I don't understand when I sent the plural function as translations didn't pass the tests, as singular has passed. After feedback, now plural has not passed the test.

[nstjean]

@ricardosantosdev That was my mistake! Apparently the singular form is correct.

[ricardotenv]

@nstjean Alright, I'll fix the PR again, thanks for the feedback